Fix inserter expecting experimental settings to exist in the context #24554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
added
[Feature] Inserter
|
Size Change: +158 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Aug 13, 2020
packages/block-editor/src/components/inserter/hooks/use-patterns-state.js
Outdated
Show resolved
Hide resolved
This was referenced Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24051
While reviewing this PR that's trying to integrate the block editor directly in WP Calypso, I noticed that the inserter is expecting these experimental settings to exist in the context:
__experimentalBlockPatternsand__experimentalBlockPatternCategories. Which doesn't seem correct, especially since they're experimental.This PR changes it so they use empty arrays by default. But please let me know if there's a better way to handle this. :)